SDL based display emulation driver #9149

vanwinkeljan · 2018-07-27T06:04:59Z

This driver introduces an emulated LCD display for the native POSIX board.
The emulated display driver makes use of SDL2 to render the displays frame
buffer into a dedicated desktop window.

Bellow is a screenshot of the LVGL sample build and running for native_posix board:

aescolar · 2018-07-27T07:31:29Z

Related to #7833 & #6826

ext/lib/gui/Kconfig

SebastianBoe

From a build perspective this is OK.

Except that it disallows using cmake 3.8, but 3.8 is arguably the best version because it is not affected by bug: #8355

So to merge this one must either drop the cmake bump or keep the cmake bump and fix #8355 somehow.

Also, bumping the version requires an email to the mailing list that warns about the dependency change and an update of the getting started docs.

vanwinkeljan · 2018-07-31T10:49:02Z

@SebastianBoe Note that only the two last commits are the actual pull request, the remaining commits are part of #6826 and #7833. I will take your comments along in #6826.

cmake/app/boilerplate.cmake

include/display.h

drivers/display/display_ili9340.c

ext/lib/gui/lvgl/lv_conf.h

samples/gui/lvgl/src/main.c

drivers/display/display_sdl.c

samples/gui/lvgl/src/main.c

samples/gui/lvgl/README.rst

vanwinkeljan · 2018-08-12T12:48:05Z

@aescolar Could review the last commit (native_posix: Added polling for SDL events)?

boards/posix/native_posix/CMakeLists.txt

boards/posix/native_posix/hw_models_top.c

boards/posix/native_posix/sdl_model.c

drivers/display/Kconfig.sdl

drivers/display/display_sdl.h

drivers/display/Kconfig.sdl

aescolar

I think it is much better now. this should lead to less overhead, more responsiveness on the GUI part, and better decoupling of future code.

boards/posix/native_posix/hw_models_top.c

boards/posix/native_posix/sdl_event_loop.c

drivers/display/Kconfig.sdl

ext/lib/gui/lvgl/lvgl_mem_kernel.c

vanwinkeljan · 2018-10-20T22:18:07Z

Changes:

Removed dependency on lvgl (Added support for LittlevGL library #6826) and use character framebuffer subsystem instead (including sample).
@nashif can you remove DNM label as this PR has no longer any dependencies on other PR?
Added extra posix signal to sdl event loop to prevent crash in case events pop up during driver initialization
Small corrections in cfb and SSD1306 & SDD1673 drivers (Character framebuffer for monochrome dot matrix displays #9035)
@jfischer-phytec-iot please review

codecov-io · 2018-10-20T22:39:03Z

Codecov Report

Merging #9149 into master will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9149      +/-   ##
==========================================
+ Coverage   48.13%   48.34%   +0.21%     
==========================================
  Files         281      264      -17     
  Lines       43425    42164    -1261     
  Branches    10406    10135     -271     
==========================================
- Hits        20902    20386     -516     
+ Misses      18368    17700     -668     
+ Partials     4155     4078      -77

Impacted Files	Coverage Δ
boards/posix/native_posix/hw_models_top.c	`92.15% <ø> (ø)`	⬆️
drivers/clock_control/nrf5_power_clock.c	`40.17% <0%> (-11.93%)`	⬇️
lib/cmsis_rtos_v1/cmsis_semaphore.c	`60% <0%> (-10%)`	⬇️
drivers/timer/nrf_rtc_timer.c	`89.13% <0%> (-5.61%)`	⬇️
kernel/work_q.c	`94.73% <0%> (-5.27%)`	⬇️
drivers/ethernet/eth_native_posix.c	`23.07% <0%> (-3.71%)`	⬇️
lib/fdtable.c	`26.08% <0%> (-3.25%)`	⬇️
subsys/net/ip/udp.c	`61.45% <0%> (-3.13%)`	⬇️
include/net/net_if.h	`60% <0%> (-2.83%)`	⬇️
drivers/net/loopback.c	`77.77% <0%> (-2.23%)`	⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49466e0...c375313. Read the comment docs.

vanwinkeljan · 2018-11-19T08:45:58Z

@aescolar Thx for all the review effort!

boards/posix/native_posix/doc/board.rst

samples/display/cfb/README.rst

dbkinder

Docs LGTM, thanks.

vanwinkeljan · 2018-11-21T10:53:42Z

@SebastianBoe could you revisit you review?

SebastianBoe · 2018-11-23T10:52:24Z

@SebastianBoe could you revisit you review?

I see that the original review comment stated that this would require a bump in the CMake version. Which has not happened. Is this still valid?

vanwinkeljan · 2018-11-23T11:56:51Z

I see that the original review comment stated that this would require a bump in the CMake version. Which has not happened. Is this still valid?

There is no need to up step CMake anymore as west will be used instead and actually the up step was not needed for this PR but for PR #6826.

nashif

please replace subsys: in your commit messages and put the actual subsys you are changing.

nashif · 2018-11-23T13:00:55Z

@aescolar please review

aescolar · 2018-11-23T13:02:10Z

@nashif : I did. This PR is DNM, being blocked by #11351.
Once #11351 is merged those extra commits can be removed from this PR, and then it could be merged.

vanwinkeljan · 2018-11-23T13:03:53Z

@aescolar Thx was just typing my self that this PR is blocked

vanwinkeljan · 2018-11-24T12:30:54Z

@nashif replaced subsys with cfb in commit message

nashif · 2018-12-10T22:22:30Z

please rebase

This driver introduces an emulated LCD display for the native POSIX board. The emulated display driver makes use of SDL2 to render the displays frame buffer into a dedicated desktop window. Signed-off-by: Jan Van Winkel <[email protected]>

Added support for native posix board to character framebuffer sample. Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan · 2018-12-10T22:51:17Z

@nashif done

vanwinkeljan requested review from dbkinder, nashif and SebastianBoe as code owners July 27, 2018 06:05

SebastianBoe reviewed Jul 31, 2018

View reviewed changes

ext/lib/gui/Kconfig Outdated Show resolved Hide resolved

SebastianBoe requested changes Jul 31, 2018

View reviewed changes

nashif added the DNM This PR should not be merged (Do Not Merge) label Jul 31, 2018

pizi-nordic self-requested a review July 31, 2018 13:49

nashif added the area: Display label Jul 31, 2018

This was referenced Jul 31, 2018

Display api #7833

Merged

Added support for LittlevGL library #6826

Merged

pizi-nordic reviewed Aug 1, 2018

View reviewed changes

dbkinder previously requested changes Aug 7, 2018

View reviewed changes

samples/gui/lvgl/README.rst Outdated Show resolved Hide resolved

samples/gui/lvgl/README.rst Outdated Show resolved Hide resolved

samples/gui/lvgl/README.rst Outdated Show resolved Hide resolved

vanwinkeljan force-pushed the sdl_display branch from 11772e8 to 240cdfd Compare August 12, 2018 12:43

vanwinkeljan requested a review from aescolar as a code owner August 12, 2018 12:43

aescolar reviewed Aug 12, 2018

View reviewed changes

vanwinkeljan force-pushed the sdl_display branch 2 times, most recently from 56bc8c1 to e3352d5 Compare August 18, 2018 20:56

aescolar reviewed Aug 19, 2018

View reviewed changes

vanwinkeljan force-pushed the sdl_display branch from e3352d5 to 11b1e31 Compare August 19, 2018 20:33

vanwinkeljan force-pushed the sdl_display branch from 11b1e31 to 18dcc90 Compare September 9, 2018 10:26

vanwinkeljan force-pushed the sdl_display branch 2 times, most recently from fa32576 to ab24fda Compare October 3, 2018 19:15

vanwinkeljan force-pushed the sdl_display branch from ab24fda to e4239ac Compare October 20, 2018 22:07

vanwinkeljan changed the title ~~[DNM][RFC] SDL based display emulation driver~~ SDL based display emulation driver Oct 20, 2018

vanwinkeljan force-pushed the sdl_display branch from e4239ac to d9d096e Compare October 20, 2018 22:43

dbkinder suggested changes Nov 19, 2018

View reviewed changes

boards/posix/native_posix/doc/board.rst Outdated Show resolved Hide resolved

samples/display/cfb/README.rst Outdated Show resolved Hide resolved

samples/display/cfb/README.rst Outdated Show resolved Hide resolved

vanwinkeljan force-pushed the sdl_display branch from 57f4b81 to d9e5c20 Compare November 20, 2018 20:40

vanwinkeljan mentioned this pull request Nov 20, 2018

Window write support for SSD1673 #11351

Merged

dbkinder approved these changes Nov 20, 2018

View reviewed changes

pizi-nordic approved these changes Nov 21, 2018

View reviewed changes

vanwinkeljan mentioned this pull request Nov 22, 2018

Introduce the cfb_shell sample app #11072

Merged

SebastianBoe approved these changes Nov 23, 2018

View reviewed changes

nashif approved these changes Nov 23, 2018

View reviewed changes

nashif assigned aescolar Nov 23, 2018

aescolar added the Blocked Blocked by another PR or issue label Nov 23, 2018

aescolar removed their assignment Nov 23, 2018

vanwinkeljan force-pushed the sdl_display branch from d9e5c20 to 917e012 Compare November 24, 2018 12:29

vanwinkeljan force-pushed the sdl_display branch from 917e012 to dcdd3b2 Compare December 1, 2018 18:42

nashif removed the Blocked Blocked by another PR or issue label Dec 10, 2018

vanwinkeljan added 2 commits December 10, 2018 23:44

driver: SDL based display emulation driver

4e8f798

This driver introduces an emulated LCD display for the native POSIX board. The emulated display driver makes use of SDL2 to render the displays frame buffer into a dedicated desktop window. Signed-off-by: Jan Van Winkel <[email protected]>

samples: Added native posix board to cfb sample

c375313

Added support for native posix board to character framebuffer sample. Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan force-pushed the sdl_display branch from dcdd3b2 to c375313 Compare December 10, 2018 22:45

vanwinkeljan removed the DNM This PR should not be merged (Do Not Merge) label Dec 10, 2018

nashif merged commit eef1099 into zephyrproject-rtos:master Dec 11, 2018

vanwinkeljan mentioned this pull request Dec 11, 2018

Dummy Display driver for native_posix #12001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDL based display emulation driver #9149

SDL based display emulation driver #9149

vanwinkeljan commented Jul 27, 2018 •

edited

Loading

aescolar commented Jul 27, 2018 •

edited

Loading

SebastianBoe left a comment

vanwinkeljan commented Jul 31, 2018

vanwinkeljan commented Aug 12, 2018

aescolar left a comment •

edited

Loading

vanwinkeljan commented Oct 20, 2018

codecov-io commented Oct 20, 2018 •

edited

Loading

vanwinkeljan commented Nov 19, 2018

dbkinder left a comment

vanwinkeljan commented Nov 21, 2018

SebastianBoe commented Nov 23, 2018 •

edited

Loading

vanwinkeljan commented Nov 23, 2018 •

edited

Loading

nashif left a comment

nashif commented Nov 23, 2018

aescolar commented Nov 23, 2018 •

edited

Loading

vanwinkeljan commented Nov 23, 2018 •

edited

Loading

vanwinkeljan commented Nov 24, 2018

nashif commented Dec 10, 2018

vanwinkeljan commented Dec 10, 2018

SDL based display emulation driver #9149

SDL based display emulation driver #9149

Conversation

vanwinkeljan commented Jul 27, 2018 • edited Loading

aescolar commented Jul 27, 2018 • edited Loading

SebastianBoe left a comment

Choose a reason for hiding this comment

vanwinkeljan commented Jul 31, 2018

vanwinkeljan commented Aug 12, 2018

aescolar left a comment • edited Loading

Choose a reason for hiding this comment

vanwinkeljan commented Oct 20, 2018

codecov-io commented Oct 20, 2018 • edited Loading

Codecov Report

vanwinkeljan commented Nov 19, 2018

dbkinder left a comment

Choose a reason for hiding this comment

vanwinkeljan commented Nov 21, 2018

SebastianBoe commented Nov 23, 2018 • edited Loading

vanwinkeljan commented Nov 23, 2018 • edited Loading

nashif left a comment

Choose a reason for hiding this comment

nashif commented Nov 23, 2018

aescolar commented Nov 23, 2018 • edited Loading

vanwinkeljan commented Nov 23, 2018 • edited Loading

vanwinkeljan commented Nov 24, 2018

nashif commented Dec 10, 2018

vanwinkeljan commented Dec 10, 2018

vanwinkeljan commented Jul 27, 2018 •

edited

Loading

aescolar commented Jul 27, 2018 •

edited

Loading

aescolar left a comment •

edited

Loading

codecov-io commented Oct 20, 2018 •

edited

Loading

SebastianBoe commented Nov 23, 2018 •

edited

Loading

vanwinkeljan commented Nov 23, 2018 •

edited

Loading

aescolar commented Nov 23, 2018 •

edited

Loading

vanwinkeljan commented Nov 23, 2018 •

edited

Loading